Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of @apollo/client (3.12.5) broke the build #650

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jan 11, 2025

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name version specification new version
@apollo/client ^3.7.14 3.12.5

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of @apollo/client for this test run.

What changed?

✳️ @​apollo/client (^3.7.14 → 3.12.5) · Repo · Changelog

Release Notes

3.12.5

Patch Changes

  • #12252 cb9cd4e Thanks @jerelmiller! - Changes the default behavior of the MaybeMasked type to preserve types unless otherwise specified. This change makes it easier to upgrade from older versions of the client where types could have unexpectedly changed in the application due to the default of trying to unwrap types into unmasked types. This change also fixes the compilation performance regression experienced when simply upgrading the client since types are now preserved by default.

    A new mode option has now been introduced to allow for the old behavior. See the next section on migrating if you wish to maintain the old default behavior after upgrading to this version.

    Migrating from <= v3.12.4

    If you've adopted data masking and have opted in to using masked types by setting the enabled property to true, you can remove this configuration entirely:

    -declare module "@apollo/client" {
    -  interface DataMasking {
    -    mode: "unmask"
    -  }
    -}

    If you prefer to specify the behavior explicitly, change the property from enabled: true, to mode: "preserveTypes":

    declare module "@apollo/client" {
      interface DataMasking {
    -    enabled: true
    +    mode: "preserveTypes"
      }
    }

    If you rely on the default behavior in 3.12.4 or below and would like to continue to use unmasked types by default, set the mode to unmask:

    declare module "@apollo/client" {
      interface DataMasking {
        mode: "unmask";
      }
    }

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-wordpress-starter ❌ Failed (Inspect) Jan 11, 2025 0:30am

Copy link
Contributor Author

depfu bot commented Jan 15, 2025

Closed in favor of #652.

@depfu depfu bot closed this Jan 15, 2025
@depfu depfu bot deleted the depfu/check/npm/@apollo/client-3.12.5 branch January 15, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants