migrates to github actions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
Mar 12, 2022
There was a problem hiding this comment.
I see https://github.com/simonneutert/strava-ruby-client/runs/5522237082?check_suite_focus=true has failures, do you have a green pass?
I think you need to lock ActiveSupport to <= 6 and we can fix 7 later.
|
please verify my changes for |
dblock
requested changes
Mar 12, 2022
|
Oh and add a CHANGELOG entry for this one. |
dblock
reviewed
Mar 12, 2022
|
I cleaned up the code @dblock |
line 14 in |
|
I hope this is working fine now, else you might need to get your hands dirty, sorry 😞 |
|
I merged it, will cleanup next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i hope this is what you'd wanted to see, copied the key from the link you provided.
https://github.com/slack-ruby/slack-ruby-bot-server/pull/142/files
closes #42