Rate limiting #61
Closed
Rate limiting #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamwolf Rebase this change so that it doesn't have any conflicts and get it to green, I'll take a look at the PR once it's there! Feel free to squash all the changes, but you don't have to. |
this is a draft
* Added changelog entry * Changed some switch-cases on foo.class.name to if foo.is_a? * Removed old ruby.yml workflow file
I'm not 100% sure this is what was meant vs adding this to Model.
To do this, I tweaked RaiseError a bit. I'm not sure if there's a better way, or if this is not worth the change, or ....
|
I rebased and the tests are green locally. Github says it needs maintainer approval to run workflows since I'm a first-time contributor here. |
Generated by 🚫 Danger |
dblock
requested changes
Jun 23, 2022
There was a problem hiding this comment.
Excellent work!
- Needs documentation in README.
- Update https://github.com/dblock/strava-ruby-client/blob/master/UPGRADING.md that explains any interface changes as low level APIs return a different type of object.
- Could use some more tests for responses that don't have
.ratelimit. - Get it to green, see CI failures on various rubies (you should be able to see actions run on your own fork if it limits them in the PR because of the first time contributor thing).
| end | ||
| end | ||
| end | ||
| # rubocop:enable Style/MissingRespondToMissing |
There was a problem hiding this comment.
We should implement respond_to here as well, shouldn't we?
|
Thanks @simonneutert for finishing this up! See #50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to help with getting @simonneutert's rate limiting work for #11 over the finish line.
I'm handy with git, so feel free to ask me to rebase/squash/do whatever!
I'm not sure about all the choices I made handling the feedback from #50, especially the ResponseWrap/RaiseError thing.
Related: