Release 3.1.57 (Develop) #1660
Open
Release 3.1.57 (Develop) #1660
+568
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit dd13184)
To reduce time spent on the splash screen, recent changes skip refreshing the online mod list if older version is found in IndexedDB cache. This means the user might have outdated mod list when importing a profile, and the manager can't import mods it doesn't know about. To mitigate the issue, a warning was added to profile preview step with an option for the user to update the mod list. However, the warning uses the mod list in Vuex to check if a mod is available, which is a mistake since that only checks if the mod itself is known, and not whether the mod version in the profile is known. This caused recently updated mods to not always trigger the warning. The download part uses IndexedDB as its source of truth, and silently ignored the unknown mods/versions, since user has explicitly decided to import a partial profile. To fix the issue, both parts now use IndexedDB as the source of truth. The implementation in ImportProfileModal now somewhat akwardly handles the mod information as ExportMods (read from mods.yml and required to know which mods are disabled), ThunderstoreMods (required to use existing UI components), and ThunderstoreCombos (required to download a specific version of the mod). This could potentially be simplified but is outside the scope of this PR. ExportMod support was dropped from TsModsModule functions to remove the footgun that caused this whole problem.
Fix profile import silently leaving some mods uninstalled
Add game: Gang Beasts
Add R.E.P.O.
Added dispatch to update API cache in background if cache was already present
Release 3.1.57
The empty value returned by the API is null, not undefined. This caused the button to be erroneously rendered on OnlineModList where strict check against undefined was used. Clicking the button then caused an unhandled error.
- This reverts an accidental change which was made previously
Update game cover images for Gang Beasts, R.E.P.O., and Zort
Add game: Disco Elysium
Add game: Odd Remedy
Add 3 new games: Dusk, Monster Train 2 and My Dream Setup
Only filter out versions when not dealing with modpacks
Fix OnlineModList rendering donate buttons for mods without donation links
A warning was logged when the actual prop passed to the component overwrote the default value.
Remove default value definition to avoid causing rerendering
Change how profile import wizard waits for online mod list refresh
The part of the profile import that force refreshes online mod list didn't take into account that active mod downloads blocks the refresh. The import modal will now wait for downloads to finish before triggering the online mod list refresh.
Show if active mod downloads are blocking a profile import
The bug was that the download function didn't use the `singleModProgressCallback` like it was supposed to (instead using `totalProgressCallback`)
Fix download progress getting stuck
Toggling the setting didn't take place immediately everywhere. Assumedly this is due to Vuex not detecting changes in a class based object. To fix this, the setting is encapsulated completely in Vuex: the value is initialized when settings are loaded, it's changed only through a Vuex action, and it's always read from Vuex state. The only exception to this is the ManagerSettingsMigration but I assume this is such a niche case it's not worth addressing.
Fix state drift of ignoreCache setting
Add installation tracking to mod installation when it's initiated by a link
Add Schedule I
Fix game cover image definition
Fix focus styles for buttons
add hades 2 egs
* Gatekeeper * Pulsar: Lost Colony * Songs of Conquest * White Knuckle
…Monitor - Added a corresponding vuex mutation - Separated indexOfDownloadProgress function - Removed the "There was a mismatch between download update's assign ID" check as that is now expected behavciour when a download is removed from the list.
Add a button to remove an inactive download from the list in DownloadMonitor
Add a button which clears all inactive downloads form the list in DownloadMonitor
Add 4 new games
Update Schedule I cover image
Fix a typo in GameManager
Add a checkbox confirmation to ImportProfileModal when partially importing a profile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.