Run metricd more frequently in functional tests #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metricd thread in the functional tests waits for 100ms between runs. This is actually quite a long time to wait, as the functional tests can run much faster than that. This results in a race condition where earlier tests submit measures, and they are not actually processed by the time the test that needs them is run, and fails because they are not done (and there's no waits or retries or anything). Tighten up the metricd thread loop so that it waits only 10ms between runs. This will increase load but the more frequent runs should be good enough for the tests to pass.
|
Didn't seem to fix the issue as I'd hoped. I'll try and spend some time next week investigating this. |
|
Closing, working solution provided in PR #1386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metricd thread in the functional tests waits for 100ms between runs.
This is actually quite a long time to wait, as the functional tests can run much faster than that. This results in a race condition where earlier tests submit measures, and they are not actually processed by the time the test that needs them is run, and fails because they are not done (and there's no waits or retries or anything).
Tighten up the metricd thread loop so that it waits only 10ms between runs. This will increase load but the more frequent runs should be good enough for the tests to pass.