Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix review issues #192

Merged
merged 160 commits into from
Dec 18, 2018
Merged

Fix review issues #192

merged 160 commits into from
Dec 18, 2018
+3,043 −2,455

Conversation

Gondolav
Copy link
Member

@Gondolav Gondolav commented Dec 12, 2018 •
edited
Loading

This pull request resolves (partially) #189 with the following changes:

  • Change drawing activities name
  • Change Database.java from enum to utility class
  • Change names: Activity to BaseActivity and BaseActivity to NoBackPressActivity
  • Remove getString from UsernameInputWatcher
  • Move Glide logic into a separate class, GlideUtils
  • Make special mode items immutable
  • Change DatabaseReferenceBuilder to private
  • Move methods and fields inside Items into RandomItemGenerator
  • Create interfaces for the local database classes
  • Define constants for keys used in getting and putting extras
  • Create FbFunctions
  • Create FbAuthentication
  • FbStorage (not PaintView anymore) keeps track of the storage reference for sendBitmapToFirebaseStorage
  • FbStorage now has a function for removing images
  • Move Firebase Database logic in a separate class
  • Move Firebase Database related methods from Account to Database
  • Change GameResult in separate view-model classes
  • Remove if conditions used only for testing and increase timeout for the game
  • Reformat code and optimize all imports

Sorry, something went wrong.

Gondolav and others added 30 commits December 11, 2018 11:16
@Gondolav
Rename drawing classes, Activity and BaseActivity
24eabcc
@Gondolav
Rename drawing classes in tests
302abed
@Gondolav
Fix line 147 problem in LoadingScreenActivity
71a83c1
@Gondolav
Change to utility class from enum
00fa01c
@Gondolav
Merge branch 'master' into fix-review-issues
cdb2eae
@rbischof
Added first methods to Database and refactored code in UsernameInputW…
425d4ae 
…atcher
@rbischof
Changed AccountCreationActivity method
0482202
@LudoHoff
Remove player limit in leaderboard
13a8c31
@LudoHoff
Merge branch 'fix-review-issues' of https://github.com/Claudio5/SDP i…
57d4bab 
…nto fix-review-issues
@rbischof
Replaced all database logic into database class
a0445c9
@Gondolav
Add GlideUtils.java
c074bc0
@Gondolav
Add GlideUtils usage instead of exposing directly Glide
3123f20
@Gondolav
Change constructor to package-private and fix warning using format()
906ad66
@Gondolav
Remove useless onCreate
fc21660
@Gondolav
Add javadocs and change signatures
e712c3a
@Gondolav
Change background animation id to backgroundAnimationId
c01b933
@Gondolav
Fix GlideUtils usage
4a8821b
@Gondolav
Replace static factories with constructor calls and enforce immutability
756bbd9
@Gondolav
Make the DatabaseReferenceBuilder private and remove constructBuilder()
63ea2c3
@Gondolav
Remove useless tests
229152c
@Gondolav
Change constructBuilder usage to getReference
d8fec77
@Gondolav
Remove useless tests
7c68bc0
@Gondolav
Fix view id in HomeActivityTest
45511fb
@Gondolav
Remove setters and make fields final
7e12f4a
@Gondolav
Create interfaces for LocalDb classes
efb12bf
@Gondolav
Add constants for the keys in put/getExtras
806e2f0 
The class putting the extra defines it as a public static final String 
KEY
@rbischof
Updated testUsers to recognize the newly created test users
1f798f5
@rbischof
Moved 2 database related methods from Account to Database and added j…
9676f33 
…avadocs
@Gondolav
Replace LocalDbHandler classes definitions/parameters with equivalent…
9388689 
… interface
@Gondolav
Add constants usage in tests for keys in put and getExtra
ac36baf
@rbischof rbischof changed the title WIP: Fix review issues Fix review issues Dec 17, 2018
@rbischof rbischof merged commit a6af057 into master Dec 18, 2018
@LudoHoff LudoHoff deleted the fix-review-issues branch December 19, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Claudio5 Claudio5

@rbischof rbischof

@LudoHoff LudoHoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gondolav @Claudio5 @rbischof @LudoHoff