Skip to content
This repository was archived by the owner on Jul 27, 2020. It is now read-only.

Fix separation between Home and HomeViewModel #96

Closed
glsubri opened this issue May 14, 2020 · 1 comment · Fixed by #100
Closed

Fix separation between Home and HomeViewModel #96

glsubri opened this issue May 14, 2020 · 1 comment · Fixed by #100
Assignees
@glsubri

Comments

@glsubri
Copy link
Contributor

glsubri commented May 14, 2020

The HomeViewModel should not be responsible for colors, drawables etc
@glsubri glsubri self-assigned this May 14, 2020
@alexandrepiveteau alexandrepiveteau mentioned this issue May 14, 2020
Merged
@alexandrepiveteau
Copy link
Member

The PR #99 is dependent on this (QR code icon does not change icon on error state).

@glsubri glsubri mentioned this issue May 14, 2020
Merged
@glsubri glsubri linked a pull request May 14, 2020 that will close this issue
Seperates HomeActivity and HMV better #100
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glsubri glsubri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Seperates HomeActivity and HMV better glsubri/android-frontend
2 participants
@glsubri @alexandrepiveteau