Skip to content

Commit 89d5728

Browse files
Gcolon021Luke Sikina
and
Luke Sikina
authoredNov 18, 2024··
[ALS-7760] Replicate Old Search in new Data-Dictionary (#53)
**[CHORE] GH Actions Fix** - Fixed GitHub Actions to resolve workflow issues. **Testing Enhancements** - Added `@ActiveProfiles("test")` to testing classes to remove spam logs from `DataSourceVerifier` during unit tests. **JSON Parsing Refactor** - Created `JsonBlobParser` for improved JSON parsing. - Refactored `ConceptResultSetUtil` to use `JsonBlobParser` for clearer separation of concerns. **Code Cleanup** - Removed unused imports from `ConceptShell` and `ContinuousConcept` classes to improve code readability. **Legacy Search Feature** - Implemented a new legacy search feature including service, controller, and related model classes. - Updated `ConceptRepository` to support legacy search queries. - Added test cases to ensure functionality. **Testing Improvements** - Added unit tests for `LegacySearchQueryMapper` to validate JSON parsing and string replacement. - Introduced integration tests for `LegacySearchController` to verify search response correctness using a PostgreSQL container. **Initial Configurations** - Added application properties for database configuration and dashboard settings. - Introduced Docker commands for local development with sample weights configuration. - Included `weights.csv` and `dictonaryRequest.http` as sample data for testing API requests. **Search Query Refactor** - Created `LegacySearchRepository` to handle legacy search functionalities. - Moved query logic (`ALLOW_FILTERING_Q`) to `QueryUtility`. - Removed legacy search code from `ConceptRepository` for better separation of concerns. **Filter Processing Refactor** - Introduced `FilterProcessor` to centralize filter processing logic. - Enhanced methods in `MetadataResultSetUtil` (`getDescription`, `getParentName`, `getParentDisplay`) for better validation using `StringUtils`. **Repository Enhancements** - Added `LegacySearchRepositoryTest` to verify legacy search functionalities. - Refactored legacy search logic from `ConceptService` into `LegacySearchRepository`. - Cleaned up unused imports and methods for better maintainability. --- Co-authored-by: Luke Sikina <lucas.skina@gmail.com>
1 parent cd06343 commit 89d5728

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+828
-101
lines changed
 

‎dictionaryweights/README.md

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
## Docker commands for local development
2+
### Docker build
3+
```bash
4+
docker build --no-cache --build-arg SPRING_PROFILE=bdc-dev -t weights:latest .
5+
```
6+
7+
### Docker run
8+
You will need a local weights.csv file.
9+
```bash
10+
docker run --rm -t --name dictionary-weights --network=host -v ./weights.csv:/weights.csv weights:latest
11+
```
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
spring.application.name=dictionaryweights
2+
spring.main.web-application-type=none
3+
4+
spring.datasource.url=jdbc:postgresql://localhost:5432/dictionary_db?currentSchema=dict
5+
spring.datasource.username=username
6+
spring.datasource.password=password
7+
spring.datasource.driver-class-name=org.postgresql.Driver
8+
9+
weights.filename=/weights.csv

0 commit comments

Comments
 (0)
Please sign in to comment.