[ALS-7760] Replicate Old Search in new Data-Dictionary #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcolon021
changed the title
This removes the spam from the DataSourceVerifier when running unit test.
Created JsonBlobParser.java for JSON parsing and refactored ConceptResultSetUtil to use it for clearer separation of concerns.
This commit cleans up the code by removing unused imports in the ConceptShell and ContinuousConcept classes. This reduces clutter and improves code readability.
Implemented a new legacy search feature including service, controller, and related model classes. Updated the ConceptRepository to support legacy search queries and added test cases to ensure functionality.
Introduces unit tests for `LegacySearchQueryMapper` to validate JSON parsing and string replacement functionality. Adds integration tests for `LegacySearchController` to verify search response correctness using a PostgreSQL container.
Introduce application properties for database configuration and dashboard settings. Add Docker commands for local development with weights configuration. Include weights.csv as sample data and dictonaryReqeust.http for testing API requests.
Gcolon021
changed the title
Introduced `LegacySearchRepository` to handle legacy search functionalities. Consolidated query logic by moving `ALLOW_FILTERING_Q` to `QueryUtility`. Removed legacy search code from `ConceptRepository` for better separation of concerns.
Introduced a new FilterProcessor component to centralize filter processing logic. Enhanced getDescription, getParentName, and getParentDisplay methods in MetadataResultSetUtil for better validation using StringUtils.
Luke-Sikina
approved these changes
Nov 16, 2024
|
approved, but the build is failing. |
Introduced LegacySearchRepositoryTest to verify legacy search functionalities. Refactored legacy search logic out of ConceptService and into LegacySearchRepository. Updated related tests and cleaned up unused imports and methods.
Luke-Sikina
pushed a commit
that referenced
this pull request
Feb 5, 2025
**[CHORE] GH Actions Fix**
- Fixed GitHub Actions to resolve workflow issues.
**Testing Enhancements**
- Added `@ActiveProfiles("test")` to testing classes to remove spam logs from `DataSourceVerifier` during unit tests.
**JSON Parsing Refactor**
- Created `JsonBlobParser` for improved JSON parsing.
- Refactored `ConceptResultSetUtil` to use `JsonBlobParser` for clearer separation of concerns.
**Code Cleanup**
- Removed unused imports from `ConceptShell` and `ContinuousConcept` classes to improve code readability.
**Legacy Search Feature**
- Implemented a new legacy search feature including service, controller, and related model classes.
- Updated `ConceptRepository` to support legacy search queries.
- Added test cases to ensure functionality.
**Testing Improvements**
- Added unit tests for `LegacySearchQueryMapper` to validate JSON parsing and string replacement.
- Introduced integration tests for `LegacySearchController` to verify search response correctness using a PostgreSQL container.
**Initial Configurations**
- Added application properties for database configuration and dashboard settings.
- Introduced Docker commands for local development with sample weights configuration.
- Included `weights.csv` and `dictonaryRequest.http` as sample data for testing API requests.
**Search Query Refactor**
- Created `LegacySearchRepository` to handle legacy search functionalities.
- Moved query logic (`ALLOW_FILTERING_Q`) to `QueryUtility`.
- Removed legacy search code from `ConceptRepository` for better separation of concerns.
**Filter Processing Refactor**
- Introduced `FilterProcessor` to centralize filter processing logic.
- Enhanced methods in `MetadataResultSetUtil` (`getDescription`, `getParentName`, `getParentDisplay`) for better validation using `StringUtils`.
**Repository Enhancements**
- Added `LegacySearchRepositoryTest` to verify legacy search functionalities.
- Refactored legacy search logic from `ConceptService` into `LegacySearchRepository`.
- Cleaned up unused imports and methods for better maintainability.
---
Co-authored-by: Luke Sikina <lucas.skina@gmail.com>
Luke-Sikina
pushed a commit
that referenced
this pull request
Feb 5, 2025
**[CHORE] GH Actions Fix**
- Fixed GitHub Actions to resolve workflow issues.
**Testing Enhancements**
- Added `@ActiveProfiles("test")` to testing classes to remove spam logs from `DataSourceVerifier` during unit tests.
**JSON Parsing Refactor**
- Created `JsonBlobParser` for improved JSON parsing.
- Refactored `ConceptResultSetUtil` to use `JsonBlobParser` for clearer separation of concerns.
**Code Cleanup**
- Removed unused imports from `ConceptShell` and `ContinuousConcept` classes to improve code readability.
**Legacy Search Feature**
- Implemented a new legacy search feature including service, controller, and related model classes.
- Updated `ConceptRepository` to support legacy search queries.
- Added test cases to ensure functionality.
**Testing Improvements**
- Added unit tests for `LegacySearchQueryMapper` to validate JSON parsing and string replacement.
- Introduced integration tests for `LegacySearchController` to verify search response correctness using a PostgreSQL container.
**Initial Configurations**
- Added application properties for database configuration and dashboard settings.
- Introduced Docker commands for local development with sample weights configuration.
- Included `weights.csv` and `dictonaryRequest.http` as sample data for testing API requests.
**Search Query Refactor**
- Created `LegacySearchRepository` to handle legacy search functionalities.
- Moved query logic (`ALLOW_FILTERING_Q`) to `QueryUtility`.
- Removed legacy search code from `ConceptRepository` for better separation of concerns.
**Filter Processing Refactor**
- Introduced `FilterProcessor` to centralize filter processing logic.
- Enhanced methods in `MetadataResultSetUtil` (`getDescription`, `getParentName`, `getParentDisplay`) for better validation using `StringUtils`.
**Repository Enhancements**
- Added `LegacySearchRepositoryTest` to verify legacy search functionalities.
- Refactored legacy search logic from `ConceptService` into `LegacySearchRepository`.
- Cleaned up unused imports and methods for better maintainability.
---
Co-authored-by: Luke Sikina <lucas.skina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
/searchin the new dictionary to support legacy search functionality as a temporary solution for the API adapters.@ActiveProfile("test")to all unit tests that do not use a PostgreSQL Testcontainer, and@Profile("!test")to theDataSourceVerifier. This reduces unnecessary log spam from unit tests that do not provide valuable information.README.mdfile in thedictionaryweightsproject with basic instructions for running the application using Docker.bdc-devapplication.properties files for running a local development environment.Regressions
|. Previously, the search prototype split input based on punctuation, spaces, and invisible space separators using the regex[\s\p{Punct}]+.