Test OIDC tweak #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the uint64<->int64 conversion type so it can be used more widely over the code base. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Currently codecov step succeeds in main and in PRs from forks, but fails in PRs from origin. This seems to be a codecov bug but I believe we can tweak the workaround. * Always run the auth workaround step * Only try to set the codecov token if OIDC is available This should mean that: * PRs from forks will not have auth token: that works fine * pushes to main will have auth token * PRs from origin repo will have auth token (even though they should not need it) Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
force-pushed
the
test-oidc-tweak
branch
3 times, most recently
from
2889e04 to
68396dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.