Build: Backport changelog generation from jQuery #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
read -pdoesn't work in thepre-release.shscript - or at least that's my hypothesis why the script gets stuck onpre-release. I thought since Code is using it inpost-release.sh, it should also work inpre-release.sh, but maybe not?Hopefully, not it'll work. My previous testing was limited as dry-run doesn't show all these issues, so I merged the release-it PR and I tried to release an alpha for testing; that's when I hit the issue.
Backport the changelog generation script from jQuery Core. Rename the old
CHANGELOG.mdtoLEGACY_CHANGELOG.mdto not lose it, but I'm contemplating moving it to GitHub Releases.