Added test suite #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge updates from fork origin
…uppercase lettering, e.g. 'oRb oF REGreT' --> 'Orb or Regret'
leon-vd
reviewed
Feb 12, 2018
There was a problem hiding this comment.
Thanks for that. The bot is getting a bit unwieldy for one file. I haven't done a lot of tests with node.js either. I might try and refactor the code to be tidier and split up a bit, which in turn should make the test cases easier to implement, as it should have more available. Testing manually after every deploy is error prone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to move the discord initialisation into a main function to stop it from running when running tests.
I am unfamiliar with Node so I don't know if this is best practice, you might want to have a look at this and change accordingly.
I only added tests for the function I created, I might write a few more for the other functions as I try to understand them.