DM-49390: Update tagging for ghcr #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Mar 10, 2025
| @@ -76,7 +76,13 @@ notify.wrap { | |||
| // should be removed after dropping support for dockerhub | |||
| if (extraDockerTags) { | |||
| // manual constructor is needed "because java" | |||
| // since we no longer need some of the current extraDockerTags, | |||
There was a problem hiding this comment.
Would you consider removing the backward-compatibility-only 7-stack-lsst_distrib-* from the nightly/weekly/official release pipelines and instead adding it back in after line 73 in this function using something like this:
def extraTagList = Arrays.asList(extraDockerTags.split())
registryTags += extraTagList
extraTagList.each { tag ->
registryTags += "7-stack-lsst_distrib-${tag}"
}
Then the hard-coded removals below would not be needed, and the extra each loop could be removed after dropping docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.