Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42115: Add check for setting minimum number of detectors larger than the cam… #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DM-42115: Add check for setting minimum number of detectors larger than the cam… #115

wants to merge 1 commit into from

Conversation

erykoff
Copy link
Contributor

@erykoff erykoff commented Dec 12, 2023

…era.

laurenam
laurenam approved these changes Dec 12, 2023
View reviewed changes
python/lsst/fgcmcal/fgcmFitCycle.py
raise ValueError(
"Cannot set minCcdPerExp greater than the number of camera detectors.",
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of including the numbers in the logs message (i.e num requested vs. num actually in camera). And I was also wondering whether, given the large variety in number of detectors/camera, it would be better to make minCcdPerExp a fraction (with some non-zero minimum) rather than absolute number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers added. I don't want to change the meanings of these things because it's a fraction of what (total or science ccds)? But this is just a "sanity check" to make sure things are not crazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenam laurenam laurenam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erykoff @laurenam