Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI provider to GH Actions #82

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Move CI provider to GH Actions #82

merged 4 commits into from
Jan 31, 2022

Conversation

stevejalim
Copy link
Contributor

@stevejalim stevejalim commented Jan 30, 2022

Description

This changeset retains the ability to run tox locally (with its breadth of
coverage) while also leveraging GH Actions as the CI runner.

See https://github.com/mozilla/django-product-details/actions

Going deeper

To ensure we had appropriate versions of Python available, we've gone with
the matrix approach at the GHA level, and then taking advantage of the way
that tox will gracefully handle the absence of a particular python version
and keep going.

This does mean that GH tries to run tox for all versions in each python
env, but it's so fast that it should not be a blocker. It does make the
output in CI a bit harder to scan, though

Also, note that Python 3.8 is currently the default version and so is
available in all GHA envs we're using, which means that the 3.8 tests
are run every time along with the specific 3.7, 3.9 or pypy tests. We
could comment it out, but then it leaves a gap if/when GHA moves to 3.9
as the default.

Lost behaviour

Related issues

#81

Follow-up actions

  • Manual release to PyPi

@stevejalim stevejalim force-pushed the 81-move-ci-provider branch 12 times, most recently from a2160dc to 0f19de9 Compare January 31, 2022 12:40
This changeset retains the ability to run tox locally (with its breadth of
coverage) while also leveraging GH Actions as the CI runner.

To ensure we had appropriate versions of Python available, we've gone with
the matrix approach at the GHA level, and then taking advantage of the way
that tox will gracefully handle the absence of a particular python version
and keep going.

This does mean that GH tries to run tox for all versions in each python
env, but it's so fast that it should not be a blocker. It does make the
output in CI a bit harder to scan, though

Also, note that Python 3.8 is currently the default version and so is
available in all GHA envs we're using, which means that the 3.8 tests
are run every time along with the specific 3.7, 3.9 or pypy tests. We
could comment it out, but then it leaves a gap if/when GHA moves to 3.9
as the default.
@stevejalim stevejalim force-pushed the 81-move-ci-provider branch 2 times, most recently from 8ef5947 to 88f829a Compare January 31, 2022 12:59
@stevejalim stevejalim changed the title [WIP] Move CI provider to GH Actions Move CI provider to GH Actions Jan 31, 2022
@stevejalim stevejalim requested review from robhudson and pmac January 31, 2022 13:05
@pmac pmac merged commit b5502f2 into master Jan 31, 2022
@pmac pmac deleted the 81-move-ci-provider branch January 31, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants