Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset retains the ability to run tox locally (with its breadth of
coverage) while also leveraging GH Actions as the CI runner.
See https://github.com/mozilla/django-product-details/actions
Going deeper
To ensure we had appropriate versions of Python available, we've gone with
the matrix approach at the GHA level, and then taking advantage of the way
that tox will gracefully handle the absence of a particular python version
and keep going.
This does mean that GH tries to run tox for all versions in each python
env, but it's so fast that it should not be a blocker. It does make the
output in CI a bit harder to scan, though
Also, note that Python 3.8 is currently the default version and so is
available in all GHA envs we're using, which means that the 3.8 tests
are run every time along with the specific 3.7, 3.9 or pypy tests. We
could comment it out, but then it leaves a gap if/when GHA moves to 3.9
as the default.
Lost behaviour
Related issues
#81
Follow-up actions