-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jasmine, JS, Calculations #63
Open
laurennicoleroth
wants to merge
29
commits into
nyc-sea-lions-2015:master
Choose a base branch
from
laurennicoleroth:mon_march_23
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jasmine, JS, Calculations #63
laurennicoleroth
wants to merge
29
commits into
nyc-sea-lions-2015:master
from
laurennicoleroth:mon_march_23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: config.ru new file: environment.rb
new file: spec_helper.rb
modified: app/controllers/index.rb new file: app/views/sealions/edit.erb new file: app/views/sealions/index.erb new file: app/views/sealions/new.erb new file: app/views/sealions/show.erb
modified: app/controllers/sealions.rb modified: app/views/sealions/show.erb modified: database.rb modified: environment.rb
modified: Gemfile new file: app/views/layout.erb new file: public/javascripts/main.js new file: spec/javascripts/javascript_spec.js new file: spec/javascripts/support/jasmine.yml
modified: Rakefile modified: app/views/layout.erb
modified: Gemfile.lock modified: Rakefile modified: app/controllers/index.rb modified: app/views/layout.erb
new file: public/javascripts/calculator.js
modified: Gemfile.lock modified: Rakefile modified: app/controllers/index.rb modified: app/views/layout.erb modified: public/javascripts/calculator.js
modified: app/controllers/index.rb deleted: app/views/calculator.erb modified: public/javascripts/calculator.js modified: spec/javascripts/javascript_spec.js
modified: spec/javascripts/javascript_spec.js
Opened a PR at: https://github.com/laurennicoleroth/lightsaber/pull/1 to consolidate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started writing a calculator with html ui that passed a string to a function representing which button was clicked. I started realizing that keeping track of three events using this to do a calculation was a bit labor intensive for pure JS (we'll get to jQuery soon, I'm sure.)
So. I simplified (go ahead and cheer) and just have four super basic prototype methods. Writing tests in Jasmine was much easier than I expected, so I am glad I stayed for the afternoon lecture.
My guts don't work today, but I think the code in my lightsaber does. ;-)
@linkblaine @queerviolet