Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixes for Domestic Beethoven use #18

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kepper
Copy link

@kepper kepper commented Mar 29, 2022

Two minor bugs that prevent bith-annotator from working properly. Code used in the same way as Star Brightly Shining demo app.

kepper added 2 commits March 29, 2022 22:25
the `in` operator works only for objects, but `followPropertyUri` is passed as an array
redux will require a return value
@DILewis
Copy link
Contributor

DILewis commented Mar 30, 2022

These look safe, but need matching /lib changes. Could you run npm build and add the matching files?

@kepper
Copy link
Author

kepper commented Mar 30, 2022

should be fine now – thanks

kepper added 5 commits August 18, 2022 22:41

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants