Refactor: Simplify statistics code #2827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by classification
…general pie chart component
* as there was only one remaining component it, move its functionality there
…n signals per sources table
…ct statistics popup
…lity * group columns into license info and source count columns * give alternating background color to table rows
PhilippMa
force-pushed
the
feat/add-classification-column
branch
from
b83d24e to
57504de
Compare
Base automatically changed from
feat/add-classification-column
to
feat/move-criticality-display
March 4, 2025 09:52
PhilippMa
force-pushed
the
feat/move-criticality-display
branch
from
a07a4e6 to
05ee92b
Compare
Base automatically changed from
feat/move-criticality-display
to
feat/classification-pie-chart
March 5, 2025 07:47
PhilippMa
force-pushed
the
feat/classification-pie-chart
branch
2 times, most recently
from
1d56540 to
b8b2d3d
Compare
PhilippMa
force-pushed
the
feat/classification-pie-chart
branch
from
b8b2d3d to
53c990f
Compare
Base automatically changed from
feat/classification-pie-chart
to
feat/introduce_license_classification
March 12, 2025 15:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
lodashto simplify the statistics codeContext and reason for change
The statistics code was rather convoluted and also computed a bit strange metrics.
WIP: