-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/introduce license classification #2844
Draft
Hellgartner
wants to merge
125
commits into
main
Choose a base branch
from
feat/introduce_license_classification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…tion Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Still Missing: * Handle classification == 0 (show at all and blue) * Add readable text Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
To later have one without the restriction for classification > 0 Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
… same conditions * classification configuration existing * classification value != 0 Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
* Goal: No need to loop over all external classifications at every place where it is used Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…diting-option Add attribution form chip for classification
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Reasons: * All other icons are SVG based. The text based has alignment problems otherwise * This allows to differentiate between fill and stroke color which allows to improve the highlighting of not strongly colored items Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
So that the most critical files appear a the top Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
As we otherwise would be mixing frontend and backend development So that the most critical files appear a the top Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…ng-items-use-color-scheme-from-bar Feat/classification auditing items use color scheme from bar
…by classification
…lightly smaller display width
Improve layout in project statistics popup
Signal count by classification pie chart
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
ToDo: The icon still does not work Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
As we otherwise would be mixing frontend and backend development So that the most critical files appear a the top Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…tion_2 Feat/sorting by classification
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…p_and_progress_bar_colors feat: statistics popup and progress bar share same colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduce the frontend handling of license classificaitions
Context and reason for change
Match what has happened on meta side
How can the changes be tested
CI
Manual click through