Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/introduce license classification #2844

Draft
wants to merge 125 commits into
base: main
Choose a base branch
from

Conversation

Hellgartner
Copy link
Contributor

Summary of changes

Introduce the frontend handling of license classificaitions

Context and reason for change

Match what has happened on meta side

How can the changes be tested

CI
Manual click through

Hellgartner and others added 14 commits March 10, 2025 13:40

Verified

This commit was signed with the committer’s verified signature.
thisiskeithb Keith Bennett
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…tion

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Still Missing:
* Handle classification == 0 (show at all and blue)
* Add readable text

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
To later have one without the restriction for classification > 0

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
… same conditions

* classification configuration existing
* classification value != 0

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
* Goal: No need to loop over all external classifications at every place where it is used

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…diting-option

Add attribution form chip for classification
@Hellgartner Hellgartner linked an issue Mar 11, 2025 that may be closed by this pull request
Hellgartner and others added 15 commits March 11, 2025 08:45
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Reasons:
* All other icons are SVG based. The text based has alignment problems otherwise
* This allows to differentiate between fill and stroke color which allows to improve the highlighting of not strongly colored items

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
So that the most critical files appear a the top

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
As we otherwise would be mixing frontend and backend development

So that the most critical files appear a the top

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…ng-items-use-color-scheme-from-bar

Feat/classification auditing items use color scheme from bar
PhilippMa and others added 30 commits March 12, 2025 13:41
Improve layout in project statistics popup
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
ToDo: The icon still does not work

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
As we otherwise would be mixing frontend and backend development

So that the most critical files appear a the top

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
…p_and_progress_bar_colors

feat: statistics popup and progress bar share same colors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintain story branch
3 participants