Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/make classification and criticality optional #2853

Draft
wants to merge 17 commits into
base: feat/introduce_license_classification
Choose a base branch
from
Draft

Feat/make classification and criticality optional #2853

wants to merge 17 commits into from

Conversation

Hellgartner
Copy link
Contributor

Closes #2849

How can the changes be tested

  • CI
  • Use a file that has both classifications and criticality
    • Go to the view menu and toggle the corresponding features on and off and watch the corresponding features disappear
    • Default: both on
    • Edge case: Progress bar belongs to classifications and then switch off classifications. Same for criticality
    • Edge case: Selected sorting belongs to classifications and then switch off classifications. Same for criticality
    • Edge case: Both classifications and criticality are disabled --> Switch for progress bar to disappear

Base automatically changed from feat/sorting-by-classification_2 to feat/introduce_license_classification March 13, 2025 11:41
@Hellgartner Hellgartner force-pushed the feat/make-classification-and-criticality-optional branch from 618022e to e12b7e4 Compare March 14, 2025 07:12
@Hellgartner Hellgartner linked an issue Mar 14, 2025 that may be closed by this pull request
Make display of classification and criticality optional #2849
Open
@Hellgartner
feat: make user settings resettable via env variable
249be18 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: add a checkbox in the menu to check whether to show classificat…
ec372cc 
…ions

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
fix: race condition at window creation
9f193a4 
On loading the web-app, the frontend starts sending IPC requests to the backend. At this time the relevant IPC handlers might not be set-up

Fix: Load the web app only after the IPC handlers have been set-up

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: show some features only if classification is configured
b146cf0 
Features in this commit
* statistics popup,
* signal view,
* the symbols in the file tree
* the attribution chips

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
refactor: move the sorting options to a list of configurations
445ae73 
Goal: Being able to add a flag in the next step

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show classification sorting if classification display di…
b7b832f 
…sabled

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show classification progress bar if classification displ…
fcd47ef 
…ay disabled

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: add checkbox for criticality
42e1b4c 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show criticality statistics if disabled
9084a1a 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner Hellgartner force-pushed the feat/make-classification-and-criticality-optional branch from 43f585f to 9084a1a Compare March 14, 2025 08:32
@Hellgartner
feat: do not show criticality progress bar if disabled
0ec254a 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show criticality attribution chip if disabled
17c71e9 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show criticality on the package card if disabled
1de62af 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show criticality on resource tree if disabled
c8374d5 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show criticality on sort options if disabled
c038720 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
feat: do not show progress bar select if only one option
78191bb 
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner
Merge branch 'feat/introduce_license_classification' into feat/make-c…
a945586 
…lassification-and-criticality-optional

Conflicts:
	src/ElectronBackend/main/iconHelpers.ts
	src/ElectronBackend/main/menu/viewMenu.ts
@Hellgartner
refactor: post merge cleanup -- unify switchable menu handling
b925f7a 
only allow one channel to get the full user-settings information from the backend

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make display of classification and criticality optional
1 participant
@Hellgartner