Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: split into packages #165

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Refactor: split into packages #165

merged 9 commits into from
Jan 10, 2025

Conversation

Hellgartner
Copy link
Contributor

Summary of changes

Splitting up the library into sub-libraries as a preparation for adding new input file formats

Context and reason for change

  • There are a coupe of plans to add new input formats into the library, e.g. ScanCode parsing and conversion #50
  • This requires introducing a clear boundary where the current SPDX specific code ends and the opossum specific code starts
  • This is the first part of that effort

How can the changes be tested

  • should be mostly covered by ci
  • Convert a more sophisticated SPDX file with current master and the new version. Results should be identical.

@Hellgartner Hellgartner force-pushed the refactor-split-into-packages branch from c92130a to b615146 Compare January 9, 2025 16:34

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner
@Hellgartner Hellgartner force-pushed the refactor-split-into-packages branch from b1646d9 to efd2c4f Compare January 10, 2025 07:24
@Hellgartner Hellgartner marked this pull request as ready for review January 10, 2025 07:25

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner
Copy link
Contributor

@abraemer abraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was signed with the committer’s verified signature.
Hellgartner Dominikus Hellgartner
@abraemer abraemer merged commit 0f3e386 into main Jan 10, 2025
7 checks passed
@abraemer abraemer deleted the refactor-split-into-packages branch January 10, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants