Refactor uses opossum model for opossum files #202
Merged
+1,160
−545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it from a simple method to a static class method to comply with the target architecture
Hellgartner
changed the base branch from
main
to
refactor-consistent-model-pipeline
use an external converter in order to break circular dependencies
Note: Needed to tweak the model at two places: * OpossumPackage origin ids needs to be a tuple to keep it hashable * Needed to add a field for unused attributions to the ScanResults
Goal: encapsulating the conversion methods
for the old definition the tuple had to be exactly of length 1
Should be covered by roundtrip tests
abraemer
requested changes
Jan 27, 2025
* No longer using type adapter * fixing allows extra * unused variant of extra attributions now is [] instead of none
Hellgartner
force-pushed
the
refactor-uses-opossum-model-for-opossum-files
branch
from
d7e52ae to
b33f5db
Compare
abraemer
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the opossum file reading use the Opossum model to move to the target architecture defined in #193