Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new generator for testing ScanCode and migrate tests #204

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

abraemer
Copy link
Contributor

@abraemer abraemer commented Jan 24, 2025

Summary of changes

  • use faker to build a generator for ScanCode objects
  • use this to write tests

Context and reason for change

Continuation of #190
Closes #196

Verified

This commit was signed with the committer’s verified signature.
michael-valdron Michael Valdron
* move contents from resource_tree.py into convert_scancode_to_opossum.py because
 1. there is no resource_tree data structure any more (parser uses opossum_model.Resource directly)
 2. Thus there is no real logical substructure to the conversion anymore
* adapt tests accordingly (change import and file name)
* break up convert_scancode_to_opossum into a part handling the file reading and
 a part that does the conversion from one model to the other
* adapt CLI and tests accordingly
* add test that checks some general properties of the conversion
@abraemer abraemer marked this pull request as ready for review January 24, 2025 09:57
@abraemer abraemer requested a review from Hellgartner January 24, 2025 09:57
@Hellgartner Hellgartner self-assigned this Jan 27, 2025
@Hellgartner Hellgartner merged commit ff5d5d8 into main Jan 27, 2025
10 checks passed
@Hellgartner Hellgartner deleted the tests-for-scancode branch January 27, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply new flow to ScanCode
2 participants