Finalize switch flow #207
Merged
Finalize switch flow #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraemer
reviewed
Jan 28, 2025
Note: Added a converter class for scancode to Opossum to allow for individual testing
* Resolved conflicts src/opossum_lib/cli.py * Needed to adapt (as this now contains functionality which has been in cli.py) * src/opossum_lib/core/input_file.py * src/opossum_lib/core/opossum_generation_arguments.py * src/opossum_lib/core/opossum_generator.py
Goal: The different file formats should not depend on each other
Hellgartner
force-pushed
the
finalize_switch_flow
branch
from
246dcb0 to
b1d0e2d
Compare
This allows to write a rule for import linter which automatically extends on new packages
mstykow
requested changes
Jan 28, 2025
src/opossum_lib/input_formats/scancode/scancode_data_to_opossum_converter.py
Outdated
Show resolved
Hide resolved
* Remove the warning log if the output file is overwritten * It is not useful for the user as it she/he cannot react on the message * Instead, put a clearer warning in the docs + help message
abraemer
reviewed
Jan 30, 2025
src/opossum_lib/input_formats/scancode/services/scancode_format_reader.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/scancode/services/scancode_data_to_opossum_converter.py
Outdated
Show resolved
Hide resolved
mstykow
reviewed
Jan 30, 2025
src/opossum_lib/input_formats/scancode/entities/scan_code_data_model.py
Outdated
Show resolved
Hide resolved
* remove filler word data * scancode is treated as one word
* rename to file reader * make the member function private
Goal: Match the project structure as good as possible
abraemer
requested changes
Jan 31, 2025
src/opossum_lib/input_formats/opossum/services/opossum_file_reader.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/opossum/services/opossum_file_reader.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/opossum/services/convert_to_opossum.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/scancode/services/scancode_file_reader.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/opossum/services/convert_to_opossum.py
Outdated
Show resolved
Hide resolved
abraemer
requested changes
Jan 31, 2025
abraemer
approved these changes
Jan 31, 2025
mstykow
approved these changes
Jan 31, 2025
src/opossum_lib/input_formats/opossum/services/opossum_file_reader.py
Outdated
Show resolved
Hide resolved
src/opossum_lib/input_formats/opossum/services/opossum_file_reader.py
Outdated
Show resolved
Hide resolved
abraemer
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199
Goal is to move to a global flow which is