Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation about the structure/architecture of the code #250

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

abraemer
Copy link
Contributor

Document the structure of the code with a diagram and some text.

@PhilippMa PhilippMa requested a review from meretp March 17, 2025 08:15
Copy link
Contributor

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good high-level overview on the architecture and in general I like the diagram, I just have a few comments what could be improved. One more general comment, looking at the architecture/file structure I feel like you are following a certain pattern, I don't know exactly how this pattern is called, but maybe you can add a more general sentence on this as well?

@abraemer abraemer force-pushed the docs-architecture branch from 19e57a7 to 95f513a Compare March 17, 2025 16:42
@abraemer abraemer requested a review from meretp March 17, 2025 16:42
Copy link
Contributor

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abraemer abraemer merged commit 23b8c81 into main Mar 18, 2025
6 checks passed
@abraemer abraemer deleted the docs-architecture branch March 18, 2025 07:30
@abraemer abraemer mentioned this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants