Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): slot controller ssr hint attributes #2893

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat(core): slot controller ssr hint attributes #2893

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
d5c27c2
chore: nvm use lts
bennypowers Jan 13, 2025
ba4408c
chore: bump lit-labs/ssr
bennypowers Jan 13, 2025
cd54b8b
chore: bump lit/context
bennypowers Jan 13, 2025
1bddaa9
fix: update context usage for ssr
bennypowers Jan 13, 2025
ed2a4c9
fix: use lit-ssr html function
bennypowers Jan 13, 2025
0088148
fix(core): rely on lit's dom-shim
bennypowers Jan 13, 2025
837f66a
chore: update and align lit version
bennypowers Jan 13, 2025
a127114
fix(core): ssr connected callback
bennypowers Jan 13, 2025
1fffb2c
fix(elements): ssr connected callbacks
bennypowers Jan 13, 2025
9bd0874
fix(elements): table th role from context instead of dom
bennypowers Jan 13, 2025
d605a41
feat(core): wip slots decorator
bennypowers Jan 21, 2025
49c3202
fix(core): empty array check
bennypowers Jan 27, 2025
0b3dffa
fix(core): remove need for static decorator for ssr slot hints
bennypowers Jan 30, 2025
98313ce
fix(core): client-side slot controller doens't use isServer
bennypowers Jan 30, 2025
9f5ecaa
fix(core): ssr-hint-has-default-slotted attr name
bennypowers Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
fix(core): ssr-hint-has-default-slotted attr name
@bennypowers
bennypowers committed Jan 30, 2025

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 9f5ecaa4d03eaffd34157dea7c02f9ff9bfb575f
2 changes: 1 addition & 1 deletion core/pfe-core/controllers/slot-controller-server.ts
View file
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ export class SlotController implements SlotControllerPublicAPI {

static attribute = 'ssr-hint-has-slotted' as const;

static anonymousAttribute = 'ssr-hint-has-slotted-anonymous' as const;
static anonymousAttribute = 'ssr-hint-has-default-slotted' as const;

constructor(public host: ReactiveElement, ..._: SlotControllerArgs) {
host.addController(this);
2 changes: 1 addition & 1 deletion elements/pf-card/test/pf-card.e2e.ts
View file
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ test.describe(tagName, () => {
browser,
importSpecifiers: [`@patternfly/elements/${tagName}/${tagName}.js`],
demoContent: /* html */ `
<pf-card ssr-hint-has-slotted="header,default,footer">
<pf-card ssr-hint-has-default-slotted ssr-hint-has-slotted="header,footer">
<h2 slot="header">Header</h2>
<span>Body</span>
<span slot="footer">Footer</span>