baseapp-chats: edit group details (#214)

* BA-2022 group title page

* BA-2022 versioning

* BA-2022 Fix migrations

* BA-2022 Versioning

* Revert "BA-2022 Versioning"

This reverts commit ec610b2.

Author: tsl-ps2

baseapp-chats/baseapp_chats/base.py

@@ -153,7 +153,7 @@ def save(self, *args, **kwargs):
 class AbstractChatRoomParticipant(TimeStampedModel, RelayModel):
     class ChatRoomParticipantRoles(models.IntegerChoices):
         MEMBER = 1, _("member")
-        ADMIM = 2, _("admin")
+        ADMIN = 2, _("admin")
 
         @property
         def description(self):
@@ -178,7 +178,7 @@ def description(self):
 
     class Meta:
         abstract = True
-        ordering = ["created"]
+        ordering = ["-role", "profile__name"]
 
     @classmethod
     def get_graphql_object_type(cls):

baseapp-chats/baseapp_chats/graphql/mutations.py

@@ -12,12 +12,14 @@
 from django.utils import timezone
 from django.utils.translation import gettext_lazy as _
 from graphene_django.types import ErrorType
+from rest_framework import serializers
 
 from baseapp_chats.graphql.subscriptions import ChatRoomOnMessagesCountUpdate
 from baseapp_chats.utils import send_message, send_new_chat_message_notification
 
 ChatRoom = swapper.load_model("baseapp_chats", "ChatRoom")
 ChatRoomParticipant = swapper.load_model("baseapp_chats", "ChatRoomParticipant")
+ChatRoomParticipantRoles = ChatRoomParticipant.ChatRoomParticipantRoles
 Message = swapper.load_model("baseapp_chats", "Message")
 MessageStatus = swapper.load_model("baseapp_chats", "MessageStatus")
 UnreadMessageCount = swapper.load_model("baseapp_chats", "UnreadMessageCount")
@@ -32,6 +34,10 @@
 ChatRoomParticipantObjectType = ChatRoomParticipant.get_graphql_object_type()
 
 
+class ImageSerializer(serializers.Serializer):
+    image = serializers.ImageField(required=False, allow_null=True)
+
+
 class ChatRoomCreate(RelayMutation):
     room = graphene.Field(ChatRoomObjectType._meta.connection.Edge)
     profile = graphene.Field(ProfileObjectType)
@@ -129,17 +135,32 @@ def mutate_and_get_payload(cls, root, info, profile_id, participants, is_group,
                 ),
             )
         image = info.context.FILES.get("image", None)
+        serializer = ImageSerializer(data={"image": image})
+        if not serializer.is_valid():
+            return ChatRoomCreate(
+                errors=[ErrorType(field="image", messages=serializer.errors["image"])]
+            )
+
         room = ChatRoom.objects.create(
             created_by=info.context.user,
             last_message_time=timezone.now(),
             is_group=is_group,
             title=title,
-            image=image,
+            image=serializer.validated_data["image"],
         )
 
         created_participants = ChatRoomParticipant.objects.bulk_create(
             [
-                ChatRoomParticipant(profile=participant, room=room, accepted_at=timezone.now())
+                ChatRoomParticipant(
+                    profile=participant,
+                    room=room,
+                    role=(
+                        ChatRoomParticipantRoles.ADMIN
+                        if participant == profile
+                        else ChatRoomParticipantRoles.MEMBER
+                    ),
+                    accepted_at=timezone.now(),
+                )
                 for participant in participants
             ]
         )
@@ -155,6 +176,136 @@ def mutate_and_get_payload(cls, root, info, profile_id, participants, is_group,
         )
 
 
+class ChatRoomUpdate(RelayMutation):
+    room = graphene.Field(ChatRoomObjectType._meta.connection.Edge)
+
+    class Input:
+        room_id = graphene.ID(required=True)
+        profile_id = graphene.ID(required=True)
+        title = graphene.String(required=False)
+        delete_image = graphene.Boolean(default_value=False)
+        add_participants = graphene.List(graphene.ID, default_value=[])
+        remove_participants = graphene.List(graphene.ID, default_value=[])
+
+    @classmethod
+    @login_required
+    def mutate_and_get_payload(
+        cls,
+        root,
+        info,
+        room_id,
+        profile_id,
+        delete_image,
+        add_participants,
+        remove_participants,
+        **input,
+    ):
+        room = get_obj_from_relay_id(info, room_id)
+        profile = get_obj_from_relay_id(info, profile_id)
+
+        if not room or not getattr(room, "is_group", False):
+            return ChatRoomUpdate(
+                errors=[
+                    ErrorType(
+                        field="room_id",
+                        messages=[_("This room cannot be updated")],
+                    )
+                ]
+            )
+
+        if not info.context.user.has_perm("baseapp_profiles.use_profile", profile):
+            return ChatRoomUpdate(
+                errors=[
+                    ErrorType(
+                        field="profile_id",
+                        messages=[_("You don't have permission to act as this profile")],
+                    )
+                ]
+            )
+
+        add_participants = [
+            get_obj_from_relay_id(info, participant) for participant in add_participants
+        ]
+        add_participants = [
+            participant for participant in add_participants if participant is not None
+        ]
+        add_participants_ids = [participant.pk for participant in add_participants]
+
+        remove_participants = [
+            get_obj_from_relay_id(info, participant) for participant in remove_participants
+        ]
+        remove_participants = [
+            participant for participant in remove_participants if participant is not None
+        ]
+        remove_participants_ids = [participant.pk for participant in remove_participants]
+
+        # Check if added participants are blocked
+        if Block.objects.filter(
+            Q(actor_id=profile.id, target_id__in=add_participants_ids)
+            | Q(actor_id__in=add_participants_ids, target_id=profile.id)
+        ).exists():
+            return ChatRoomUpdate(
+                errors=[
+                    ErrorType(
+                        field="add_participants",
+                        messages=[_("You can't add those participants to a chatroom")],
+                    )
+                ]
+            )
+
+        if not info.context.user.has_perm(
+            "baseapp_chats.modify_chatroom",
+            {"profile": profile, "room": room, "add_participants": add_participants},
+        ):
+            return ChatRoomUpdate(
+                errors=[
+                    ErrorType(
+                        field="room_id",
+                        messages=[_("You don't have permission to update this room")],
+                    )
+                ]
+            )
+
+        title = input.get("title", None)
+        if title is not None:
+            room.title = title
+
+        image = info.context.FILES.get("image", None)
+        serializer = ImageSerializer(data={"image": image})
+        if not serializer.is_valid():
+            return ChatRoomUpdate(
+                errors=[ErrorType(field="image", messages=serializer.errors["image"])]
+            )
+
+        if image is not None:
+            room.image = serializer.validated_data["image"]
+        elif delete_image:
+            room.image = None
+
+        room.save()
+
+        for participant in remove_participants_ids:
+            # TODO: Delete participant
+            # ChatRoomParticipant.objects.filter(
+            #    profile_id=participant.pk, room=room
+            # ).delete()
+            pass
+
+        for participant in add_participants:
+            # TODO: Add participant
+            # ChatRoomParticipant.objects.create(
+            #    profile=participant, room=room, accepted_at=timezone.now()
+            # )
+            # Subscriptions?
+            pass
+
+        return ChatRoomUpdate(
+            room=ChatRoomObjectType._meta.connection.Edge(
+                node=room,
+            ),
+        )
+
+
 class ChatRoomSendMessage(RelayMutation):
     message = graphene.Field(MessageObjectType._meta.connection.Edge)
 
@@ -417,6 +568,7 @@ def mutate_and_get_payload(cls, root, info, room_id, profile_id, archive, **inpu
 
 class ChatsMutations(object):
     chat_room_create = ChatRoomCreate.Field()
+    chat_room_update = ChatRoomUpdate.Field()
     chat_room_send_message = ChatRoomSendMessage.Field()
     chat_room_read_messages = ChatRoomReadMessages.Field()
     chat_room_unread = ChatRoomUnread.Field()

baseapp-chats/baseapp_chats/graphql/object_types.py

@@ -15,15 +15,20 @@
 Profile = swapper.load_model("baseapp_profiles", "Profile")
 ChatRoom = swapper.load_model("baseapp_chats", "ChatRoom")
 ChatRoomParticipant = swapper.load_model("baseapp_chats", "ChatRoomParticipant")
+ChatRoomParticipantRoleTypesEnum = graphene.Enum.from_enum(
+    ChatRoomParticipant.ChatRoomParticipantRoles
+)
 UnreadMessageCount = swapper.load_model("baseapp_chats", "UnreadMessageCount")
 Message = swapper.load_model("baseapp_chats", "Message")
 
 
 class BaseChatRoomParticipantObjectType:
+    role = graphene.Field(ChatRoomParticipantRoleTypesEnum)
+
     class Meta:
         interfaces = (relay.Node,)
         model = ChatRoomParticipant
-        fields = ("id", "has_archived_room", "profile")
+        fields = ("id", "has_archived_room", "profile", "role")
         filter_fields = ("profile__target_content_type",)
 
 

baseapp-chats/baseapp_chats/migrations/0008_alter_chatroomparticipant_options.py

@@ -0,0 +1,17 @@
+# Generated by Django 5.0.8 on 2025-01-10 12:02
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("baseapp_chats", "0007_messagestatus_increment_unread_count"),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name="chatroomparticipant",
+            options={"ordering": ["-role", "profile__name"]},
+        ),
+    ]

baseapp-chats/baseapp_chats/permissions.py

@@ -3,45 +3,82 @@
 from django.db import models
 
 ChatRoom = swapper.load_model("baseapp_chats", "ChatRoom")
+ChatRoomParticipant = swapper.load_model("baseapp_chats", "ChatRoomParticipant")
 Block = swapper.load_model("baseapp_blocks", "Block")
 Profile = swapper.load_model("baseapp_profiles", "Profile")
 
 
 class ChatsPermissionsBackend(BaseBackend):
-    def has_perm(self, user_obj, perm, obj=None):
-        if perm == "baseapp_chats.add_chatroom" and user_obj.is_authenticated:
-            if isinstance(obj, dict):
-                participants = obj["participants"]
-                current_profile = obj["profile"]
+    def can_add_chatroom(self, user_obj, obj):
+        if isinstance(obj, dict):
+            participants = obj["participants"]
+            current_profile = obj["profile"]
+
+            if len(participants) < 2:
+                return False
 
-                if len(participants) < 2:
-                    return False
+            if current_profile:
+                my_profile_ids = [current_profile.id]
+            else:
+                my_profile_ids = Profile.objects.filter_user_profiles(user_obj).values_list(
+                    "id", flat=True
+                )
 
-                if current_profile:
-                    my_profile_ids = [current_profile.id]
-                else:
-                    my_profile_ids = Profile.objects.filter_user_profiles(user_obj).values_list(
-                        "id", flat=True
-                    )
+            participant_profile_ids = [participant.pk for participant in participants]
 
-                participant_profile_ids = [participant.pk for participant in participants]
+            blocks_qs = Block.objects.filter(
+                models.Q(actor_id__in=my_profile_ids, target_id__in=participant_profile_ids)
+                | models.Q(actor_id__in=participant_profile_ids, target_id__in=my_profile_ids)
+            )
 
-                blocks_qs = Block.objects.filter(
-                    models.Q(actor_id__in=my_profile_ids, target_id__in=participant_profile_ids)
-                    | models.Q(actor_id__in=participant_profile_ids, target_id__in=my_profile_ids)
-                )
+            if blocks_qs.exists():
+                return False
 
-                if blocks_qs.exists():
-                    return False
+            return True
 
-                return True
+    def can_modify_chatroom(self, user_obj, obj):
+        if isinstance(obj, dict):
+            room = obj["room"]
+            add_participants = obj["add_participants"]
+            current_profile = obj["profile"]
+
+            if not getattr(room, "is_group", False):
+                return False
+
+            chat_room_participant = ChatRoomParticipant.objects.filter(
+                room=room, profile_id=current_profile.pk
+            ).first()
+            if (
+                not chat_room_participant
+                or not chat_room_participant.role
+                == ChatRoomParticipant.ChatRoomParticipantRoles.ADMIN
+            ):
+                return False
+
+            participant_profile_ids = [participant.pk for participant in add_participants]
+
+            blocks_qs = Block.objects.filter(
+                models.Q(actor_id=current_profile.id, target_id__in=participant_profile_ids)
+                | models.Q(actor_id__in=participant_profile_ids, target_id=current_profile.id)
+            )
+
+            if blocks_qs.exists():
+                return False
+
+            return True
+
+    def has_perm(self, user_obj, perm, obj=None):
+        if perm == "baseapp_chats.add_chatroom" and user_obj.is_authenticated:
+            return self.can_add_chatroom(user_obj, obj)
         if perm == "baseapp_chats.add_chatroom_with_profile":
             return user_obj.has_perm("baseapp_profiles.use_profile", obj)
         if perm == "baseapp_chats.delete_chat":
             if isinstance(obj, ChatRoom):
                 return obj.user_id == user_obj.id or user_obj.has_perm(
                     "baseapp_profiles.use_profile", obj.actor
                 )
+        if perm == "baseapp_chats.modify_chatroom":
+            return self.can_modify_chatroom(user_obj, obj)
         if perm == "baseapp_chats.view_chatroom":
             my_profile_ids = Profile.objects.filter_user_profiles(user_obj).values_list(
                 "id", flat=True