Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added generation based on noir project. #79

Merged
merged 8 commits into from
Mar 27, 2025
Merged

Conversation

piohei
Copy link
Contributor

@piohei piohei commented Mar 26, 2025

This PRs introduces new way to generate output. Instead of single file whole Noir project is loaded and structure is being generated by the Lampe tool with for now only single src/main.nr extracted.

Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, asked a few questions inline, but this looks promising!


[[require]]
name = "Lampe"
path = "./../../../../Lampe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is autogenerated, it should point to lampe on github and not local

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that it is important for you to test for now. I've copied the comment and code with github commented is here https://github.com/reilabs/lampe/blob/piohei/noir_dependency_support/src/file_generator/lake/mod.rs#L20

Examples/test.sh Outdated
fi

$CLI
if [[ "$lib_name" =~ Merkle ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this? If this gets overwritten by the CLI, there should be no user-generated stuff in there, so we need to restructure the project

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - this is something I know we need to change as I agree 100%. I'm not sure how yet - need to catch up on Lean ecosystem first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've change the generated structure in latest commits.

@piohei piohei force-pushed the piohei/noir_dependency_support branch from 5c78192 to 7435395 Compare March 27, 2025 08:05
@piohei piohei force-pushed the piohei/noir_dependency_support branch from 0a2a508 to d10ee87 Compare March 27, 2025 09:14
@piohei piohei force-pushed the piohei/noir_dependency_support branch from 52fa3a6 to 23c5f5e Compare March 27, 2025 12:25

lake exe cache get
lake build

rm $extracted
mv $extracted_temp $extracted
# We need to cleanup some space in GitHub as we run out of disk space when running tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to add this hack as we run out of disk space during e2e-test CI run.

@piohei piohei requested review from kustosz and mpenciak March 27, 2025 14:12
@@ -0,0 +1,20 @@
#!/usr/bin/bash
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is file simulating "user work" with the generated files.

@piohei piohei merged commit 9a91449 into main Mar 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants