-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing infrastructure and bug fixes #82
Open
mpenciak
wants to merge
17
commits into
main
Choose a base branch
from
mp/cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1ac61d
to
7208e85
Compare
…n import in top lib file
009679f
to
aca7b46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a lot (sorry reviewers!):
Arrays
andTraitGenerics
examples as these are just copies of themtree_recover
function from theMerkle
andMerkleFromScratch
examplescli
tolampe
Extracted
module in the main library fileproven-zk
as a default lake dependencyExtracted
build target from the generated lakefile, as the currentlampe
generation places the extracted files as a submodule of the main library
lean-toolchain
file to the version used by Lampelake-manifest.json
file that points to an already-downloaded copy of mathlib.In the course of fixing the above test infrastructure, a number of issues became apparent:
would expand to
Expr.letIn ... fun v => Expr.var v
(incorrectly), and Lean would point out the type error. The new syntax expands this toExpr.letIn ... fun _ => Expr.skip
.Also fixes other terminal non-returning expressions from being interpreted as returns.
std::mem::zeroed
builtin!=
builtinExperiments
test/example to account for some open bugs on the Noir compiler (Catch unbound type variables earlier in compilation noir-lang/noir#7889) and (TBD)Examples
folder eventually.