use separate storage volume options #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi 👋 here are your HTML README previews: |
bkabrda
reviewed
Mar 27, 2025
| @@ -23,7 +23,7 @@ | |||
| label: "{{ item }}" | |||
|
|
|||
| - name: Create volume if it does not exist | |||
| ansible.builtin.command: podman volume create {{ tas_single_node_podman_volume_create_extra_args }} {{ item }} | |||
| ansible.builtin.command: podman volume create {{ lookup('vars', 'tas_single_node_' + item | replace('-', '_') + '_create_args', default='') }} {{ item }} | |||
There was a problem hiding this comment.
How about making the configuration value a dict like this:
tas_single_node_podman_volume_create_extra_args:
tuf_repository: ""
tuf_signing_keys: ""
# and so on
This would group the values together nicely and would also allow you to do something like tas_single_node_podman_volume_create_extra_args[item] here which I think is nicer.
|
Hi 👋 here are your HTML README previews: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.