adding downstream versioning #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Gregory-Pereira The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Gregory-Pereira
force-pushed
the
implement-versioning-of-downstream
branch
from
74220d7 to
307f888
Compare
Needed to pick up this commit securesign/go-version-package@c1b85a3 Signed-off-by: Lance Ball <lball@redhat.com>
Ensures that the product version is printed along with everythiing else. Signed-off-by: Lance Ball <lball@redhat.com>
|
/lgtm |
|
@Gregory-Pereira: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
JasonPowr
reviewed
Mar 14, 2024
| @@ -222,6 +224,7 @@ require ( | |||
| github.com/sagikazarmark/locafero v0.4.0 // indirect | |||
| github.com/sagikazarmark/slog-shim v0.1.0 // indirect | |||
| github.com/sassoftware/relic v7.2.1+incompatible // indirect | |||
| // github.com/securesign/go-version-package | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: https://github.com/securesign/rekor/pull/241/files