Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECURESIGN-1859: TAS e2e tests added to operator integration tests #84

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

SECURESIGN-1859: TAS e2e tests added to operator integration tests #84

wants to merge 15 commits into from

Conversation

petrpinkas
Copy link

@petrpinkas petrpinkas commented Mar 14, 2025 •
edited
Loading

https://issues.redhat.com/browse/SECURESIGN-1859

This is not yet completely ready, but I'd like to merge it, so it can be tested already in production with other types of operator (operator, operartor-bundle, ...). Should not take longer then the original e2e pipeline.

Newly:

  • TAS installation and TAS e2e tests

Still missing:

  • Only one TAS e2e tests is running at a moment, the one that does not need podman.
  • Support for podman or other way of handling images.
  • This may need to improve e2e tests itself.

Tested here: https://console.redhat.com/application-pipeline/workspaces/rhtas/applications/operator/integrationtests/rhtas-operator-e2e-test-tmp

@petrpinkas petrpinkas mentioned this pull request Mar 14, 2025
Closed
@petrpinkas petrpinkas requested review from bouskaJ and JasonPowr March 14, 2025 17:15
@petrpinkas petrpinkas marked this pull request as ready for review March 14, 2025 17:15
@petrpinkas
Copy link
Author

Before merging I'd need to update references to main branch

          - name: git-clone-operator
            ref:
              resolver: git
              params:
                - name: url
                  value: https://github.com/securesign/pipelines.git
                - name: revision
                  value: ppinkas/SECURESIGN-1859
                - name: pathInRepo
                  value: stepactions/git-clone-operator.yaml

@petrpinkas petrpinkas marked this pull request as draft March 16, 2025 13:29
@petrpinkas petrpinkas marked this pull request as ready for review March 16, 2025 22:25
bouskaJ
bouskaJ reviewed Mar 17, 2025
View reviewed changes
pipelines/rhtas-operator-e2e.yaml
- name: url
value: https://github.com/securesign/pipelines.git
- name: revision
value: ppinkas/SECURESIGN-1859
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

udate ref ppinkas/SECURESIGN-1859

pipelines/rhtas-operator-e2e.yaml Outdated
- name: url
value: https://github.com/securesign/pipelines.git
- name: revision
value: ppinkas/SECURESIGN-1859
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

pipelines/rhtas-operator-e2e.yaml
- name: url
value: https://github.com/securesign/pipelines.git
- name: revision
value: ppinkas/SECURESIGN-1859
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update

@bouskaJ bouskaJ force-pushed the ppinkas/SECURESIGN-1859 branch from 31b0b48 to 34b55c4 Compare March 17, 2025 10:43
petrpinkas
petrpinkas commented Mar 17, 2025
View reviewed changes
pipelines/rhtas-operator-e2e.yaml Outdated
@@ -368,7 +430,7 @@ spec:
openssl s_client -connect $OIDC_HOST:443 > /tmp/ssl.cert
export SSL_CERT_FILE=/tmp/ssl.cert
go mod vendor
make test-e2e | tee /dump/testOutput.log
#make test-e2e | tee /dump/testOutput.log
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to uncomment

@bouskaJ bouskaJ force-pushed the ppinkas/SECURESIGN-1859 branch 6 times, most recently from abec9b9 to 696c6fe Compare March 17, 2025 15:31
@bouskaJ bouskaJ force-pushed the ppinkas/SECURESIGN-1859 branch 24 times, most recently from 1900bec to 3d8ceaa Compare March 18, 2025 09:12
@bouskaJ bouskaJ force-pushed the ppinkas/SECURESIGN-1859 branch from 3d8ceaa to d5914d1 Compare March 18, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouskaJ bouskaJ bouskaJ left review comments

@JasonPowr JasonPowr Awaiting requested review from JasonPowr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrpinkas @bouskaJ