ci(fix): update node.js for github action + reformat files for prettier action #32
Conversation
There was a problem hiding this comment.
It looks like your editor may have auto-formatted these pipeline files. Do you really want that as part of the PR?
There was a problem hiding this comment.
I certainly can for .tekton files because they don't exist upstream, but for the other files like src/modules/components/Entry.tsx I'm not sure if we want to start ignoring those?
The other thing is if we don't commit the formatting now then it will make reviewing both merge conflicts from upstream and pull requests more difficult, however, I don't feel strongly about it so I'm happy to exclude those formatting changes if you prefer.
package.json
Outdated
| @@ -8,6 +8,8 @@ | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "format": "prettier --check --ignore-path .gitignore .", | |||
| "format:fix": "prettier --write --ignore-path .gitignore .", | |||
There was a problem hiding this comment.
Or maybe prettier is formatting the yaml? Can you add --ignore-path .tekton as well?
There was a problem hiding this comment.
Yes that was an intentional format, sorry about that! See my other comment. I'll add --ignore-path .tekton to this.
kahboom
force-pushed
the
ci-fixes-02
branch
2 times, most recently
from
cfae8cc to
8a39d30
Compare
chore: merge with main fix: revert formatting changes to .tekton files chore: rm prettier version from workflow restore deleted file, oops
|
@lance any idea why the RHTAP check is failing? the logs are really noisy and it's difficult to tell what's going on |
This PR intends to address the failing builds due to enabling GitHub Actions workflows to run.