Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Cherrypick to fix CI tests #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tommyd450
Copy link

  • fetch minisign from homebrew instead of custom ppa

  • brew is only installed by default on macos runners

  • sigh, use homebrew setup-homebrew action


* fetch minisign from homebrew instead of custom ppa

Signed-off-by: Bob Callaway <bcallaway@google.com>

* brew is only installed by default on macos runners

Signed-off-by: Bob Callaway <bcallaway@google.com>

* sigh, use homebrew setup-homebrew action

Signed-off-by: Bob Callaway <bcallaway@google.com>

---------

Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tommyd450

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tommyd450 tommyd450 changed the title fetch minisign from homebrew instead of custom ppa (#2329) Upstream Cherrypick to fix CI tests Mar 14, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@71306f8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage        ?   41.91%           
=======================================
  Files           ?      192           
  Lines           ?    24683           
  Branches        ?        0           
=======================================
  Hits            ?    10345           
  Misses          ?    13569           
  Partials        ?      769           
Flag Coverage Δ
unittests 41.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants