Trillian extend - createTree and updateTree #39
Conversation
|
|
||
| Describe("Set tree state to DRAINING", func() { | ||
| It("should update tree state", func() { | ||
| cmd := fmt.Sprintf("oc run --image registry.redhat.io/rhtas/updatetree-rhel9@sha256:1a95a2061b9bc0613087903425d84024ce10e00bc6110303a75637fb15d95d34 --restart=Never --attach=true --rm=true -q -- updatetree --admin_server=trillian-logserver:8091 --tree_id=%s --tree_state=DRAINING", currentTreeID) |
There was a problem hiding this comment.
First, avoid hard coding any version of the tested artifact binary/image in the test suite. Hard coding versions undermines the verification process.
Next, please use the same method as is used for other CLI tools to download the updatetree and createtree binaries. This ensures consistency and reliability across the codebase, and it is essential for all tests in this repository to work seamlessly on both OCP (OpenShift Container Platform) and RHEL (Red Hat Enterprise Linux) environments. The current implementation does not meet this requirement.
| }) | ||
| }) | ||
|
|
||
| Describe("Set tree state to DRAINING", func() { |
There was a problem hiding this comment.
Additionally, please do not manipulate the existing tree because it will cause problems for other tests running against this service. Instead, create a new tree that is independent and work with it. The current implementation of tests causes side effects that lead to instability in all tests.
| &cli{ | ||
| Name: "createtree", | ||
| setupStrategy: PreferredSetupStrategy(), | ||
| versionCommand: "version", |
There was a problem hiding this comment.
There is no version command in createtree cli
There was a problem hiding this comment.
I must request changes based on the following concerns: the test suite still depends heavily on an OpenShift (OCP) deployment and modifies the RHTAS instance, which is not aligned with the intended scope of this repository. These deployment-specific tests should reside in projects such as securesign/secure-sign-operator or the related Ansible project. Additionally, the original Jira issue specified a simple smoke test aimed solely at verifying the CLI binary's functionality (for example, by using the help command), so the current approach exceeds that scope. As next steps, you can move your current work into the operator repository and extend it to cover the full Rekor key rotation scenario—especially since we already have a scenario for Fulcio, so your achieved work won't go to waste. For this repository, please modify the PR to simply execute the createtree and updatetree CLI binaries by running the help command and checking that they have executed successfully.
| &cli{ | ||
| Name: "updatetree", | ||
| setupStrategy: PreferredSetupStrategy(), | ||
| versionCommand: "version", |
There was a problem hiding this comment.
There is no version command in updatetree cli. It looks like correct values should be empty string.
No description provided.