-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURESIGN-1228] add/update/remove old-style targets #23
Conversation
Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I think overall this looks good; I posted couple comments to improve certain things. We will also need these commands to modify the trusted_root.json file, but that can be improved in a different PR once the sigstore-rs PR is merged. |
6260698
to
2311ce0
Compare
@fghanmi one last comment here - when I try to remove a non-existing target, the command silently passes not doing anything. Should removing a non-existing target rather error out? When I make a typo in the target name, this would silently pass and I might not notice because I would think that the command worked. |
I was thinking it's okay to silently pass even if the target does not exist (as if it's deleted) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bkabrda, fghanmi, SequeI The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.