Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURESIGN-1228] add/update/remove old-style targets #23

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

fghanmi
Copy link

@fghanmi fghanmi commented Aug 26, 2024

No description provided.

Signed-off-by: Firas Ghanmi <fghanmi@redhat.com>
@SequeI SequeI self-assigned this Aug 26, 2024
Copy link
Collaborator

@SequeI SequeI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm label Aug 26, 2024
@bkabrda
Copy link

bkabrda commented Aug 28, 2024

I think overall this looks good; I posted couple comments to improve certain things. We will also need these commands to modify the trusted_root.json file, but that can be improved in a different PR once the sigstore-rs PR is merged.

@openshift-ci openshift-ci bot removed the lgtm label Sep 2, 2024
@fghanmi fghanmi requested a review from bkabrda September 2, 2024 07:20
@fghanmi fghanmi changed the title [SECURESIGN-1228] add/update old-style targets [SECURESIGN-1228] add/update/remove old-style targets Sep 3, 2024
@bkabrda
Copy link

bkabrda commented Sep 3, 2024

@fghanmi one last comment here - when I try to remove a non-existing target, the command silently passes not doing anything. Should removing a non-existing target rather error out? When I make a typo in the target name, this would silently pass and I might not notice because I would think that the command worked.

@fghanmi
Copy link
Author

fghanmi commented Sep 3, 2024

@fghanmi one last comment here - when I try to remove a non-existing target, the command silently passes not doing anything. Should removing a non-existing target rather error out? When I make a typo in the target name, this would silently pass and I might not notice because I would think that the command worked.

I was thinking it's okay to silently pass even if the target does not exist (as if it's deleted)
But I like more your idea. Thanks!

Copy link

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

openshift-ci bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bkabrda, fghanmi, SequeI

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fghanmi fghanmi merged commit 67ab081 into develop Sep 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants