Disable codecov patch updates #109
Conversation
This creates a decent amount of noisy comments on PRs. We have this off for other repos and codecov still works fine, generating reports for coverage for the PR. Signed-off-by: Hayden B <haydentherapper@users.noreply.github.com>
|
The codecov annotations are indeed annoying. Can you describe what this change does in practice: Does it remove the code annotations or the PR comment, or both? Examples in sigstore org may not be a good indication of best practices since it seems clear that no one actually looks at codecov coverage (based on the finding that baseline coverage is not being reported in any of the projects). |
For context I'm asking this since if this removes the PR comment then I don't understand why we use codecov. If it doesn't provide the info in the PR what's the advantage over running |
|
I was under the impression that it would drop the codecov/patch comments left throughout the PR, but still compute overall coverage and provide percent changes, like in sigstore/rekor#2413. |
There was a problem hiding this comment.
I was under the impression that it would drop the codecov/patch comments left throughout the PR, but still compute overall coverage and provide percent changes, like in sigstore/rekor#2413.
This sounds good to me 👍
|
I wonder if we should disable annotations like this instead: https://docs.codecov.com/docs/github-checks#disabling-github-checks-patch-annotations-via-yaml ? I think patch checks might still be useful, but I don't have a good grasp on how they will be surfaced without annotations. |
|
Happy to try any setup out -- I don't think I can reliably map the codecov docs to actual GitHub things, they're not to clearest docs ever |
|
Also apparently you can just use keyboard shortcut |
This creates a decent amount of noisy comments on PRs. We have this off for other repos and codecov still works fine, generating reports for coverage for the PR.
Summary
Release Note
Documentation