Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Healthcheck #115

Closed
wants to merge 3 commits into from
Closed

Conversation

ramonpetgrave64
Copy link
Collaborator

@ramonpetgrave64 ramonpetgrave64 commented Mar 19, 2025

#95

Summary

Adds a healthcheck grpc service. For now, it is imported from a pre-grenerated healthcheck service and served alongside rekor-server as another grpc service on the grpc server. Kubernetes has built-in support for checking against this service.

Testing process

No unit tests, but can be manually tested.

start the server

docker-compose up -d

invoke the grpc health prober, to see what it reports.

./grpc_health_probe-darwin-arm64 --addr localhost:3001

status: SERVING

TODO:

Release Note

Adds healthchecks.

Documentation

Adds docs about healthchecks.

Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Signed-off-by: Ramon Petgrave <ramon.petgrave64@gmail.com>
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.79%. Comparing base (c736036) to head (f2a8f8b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   21.33%   21.79%   +0.45%     
==========================================
  Files          27       27              
  Lines        1692     1716      +24     
==========================================
+ Hits          361      374      +13     
- Misses       1299     1308       +9     
- Partials       32       34       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@loosebazooka
Copy link
Member

do we want to do this healthz thing too? https://github.com/sigstore/fulcio/blob/main/cmd/app/http.go#L74

@ramonpetgrave64
Copy link
Collaborator Author

@loosebazooka I think you're right. I have something working on another branch. I'll change this PR to use that next week.

@loosebazooka
Copy link
Member

Happy to do it incrementally too

@ramonpetgrave64
Copy link
Collaborator Author

redoing in #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants