Add end to end tests #128
Draft
Add end to end tests #128
+232
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
=======================================
Coverage 26.52% 26.52%
=======================================
Files 28 28
Lines 1836 1836
=======================================
Hits 487 487
Misses 1314 1314
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
Comment on lines
+22
to
+34
| echo "waiting up to 2 minutes for system to start" | ||
| count=0 | ||
| until [ $(docker inspect rekor-tiles-rekor-1 | jq -r .[0].State.Health.Status) == "healthy" ]; | ||
| do | ||
| if [ $count -eq 24 ]; then | ||
| echo "timeout reached" | ||
| exit 1 | ||
| else | ||
| echo -n "." | ||
| sleep 5 | ||
| let 'count+=1' | ||
| fi | ||
| done |
There was a problem hiding this comment.
I think we can replace this with
docker compose up --wait --wait-timeout 60
And with the compsoe.yml changes in #142 it can be ready much more quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #113
TODO:
Summary
Release Note
Documentation