FEN-168 Make logo sx props customizable #233
Conversation
tsl-ps2
requested review from
anicioalexandre,
deboracosilveira and
priscilladeroode
as code owners
|
WalkthroughThe pull request introduces a new optional property, Changes
Sequence Diagram(s)sequenceDiagram
participant NL as NavigationLayout
participant H as Header
participant NM as NavMini
participant NV as NavVertical
participant L as Logo
NL->>H: Pass LogoProps
NL->>NM: Pass LogoProps
NL->>NV: Pass LogoProps
H->>L: Spread LogoProps
NM->>L: Spread LogoProps
NV->>L: Spread LogoProps
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/components/modules/navigations/web/Header/index.tsxOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
packages/components/modules/navigations/web/Header/types.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
packages/components/modules/navigations/web/NavMini/types.tsOops! Something went wrong! :( ESLint: 8.57.1 Error: Cannot read config file: /packages/components/.eslintrc.js
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (11)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
For FEN, we would like to use a non-quadratic logo above the menu. I therefore "forwarded" the |
tsl-ps2
force-pushed
the
FEN-168-make-logo-customizable
branch
from
d3a115d to
162a327
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/components/CHANGELOG.md (1)
3-8: Clarify the Changelog Entry for LogoProps CustomizationThe new version section for 1.0.18 is correctly placed and formatted. However, to directly tie the changelog note to the PR objectives, consider expanding the description. Specifically, mention that the forwarded
LogoPropsnow allow overriding the defaultsxproperties of the logo component. This clarification can help future maintainers and users to immediately understand that the customization is targeting the logo’s style/options, aligning with FEN-168.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
packages/components/CHANGELOG.md(1 hunks)packages/components/modules/navigations/web/Header/index.tsx(2 hunks)packages/components/modules/navigations/web/Header/types.ts(2 hunks)packages/components/modules/navigations/web/NavMini/index.tsx(2 hunks)packages/components/modules/navigations/web/NavMini/types.ts(2 hunks)packages/components/modules/navigations/web/NavVertical/index.tsx(2 hunks)packages/components/modules/navigations/web/NavVertical/types.ts(1 hunks)packages/components/modules/navigations/web/NavigationLayout/index.tsx(7 hunks)packages/components/modules/navigations/web/NavigationLayout/types.ts(1 hunks)packages/components/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/components/package.json
🚧 Files skipped from review as they are similar to previous changes (8)
- packages/components/modules/navigations/web/NavMini/types.ts
- packages/components/modules/navigations/web/Header/index.tsx
- packages/components/modules/navigations/web/NavigationLayout/types.ts
- packages/components/modules/navigations/web/NavMini/index.tsx
- packages/components/modules/navigations/web/Header/types.ts
- packages/components/modules/navigations/web/NavVertical/index.tsx
- packages/components/modules/navigations/web/NavigationLayout/index.tsx
- packages/components/modules/navigations/web/NavVertical/types.ts
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript)
- GitHub Check: Build and Lint Packages
- GitHub Check: Component Test Packages
anicioalexandre
added
the
needs changes
tsl-ps2
force-pushed
the
FEN-168-make-logo-customizable
branch
from
9e4d435 to
cdd9f60
Compare
|
As a Developer, on the Agent Portal,I would like to Implement the design system, In order to ensure consistency, maintainability, and scalability in our UI components across the application..
Summary by CodeRabbit
New Features
LogoPropscustomization option, allowing for flexible visual adjustments that improve design consistency and support better branding across the interface.LogoPropstoHeader,NavMini,NavVertical, andNavigationLayoutcomponents for improved configurability.Chores
package.jsonfile and changelog for the@baseapp-frontend/componentspackage.PartialLogoPropsto enhance the flexibility of logo properties.