Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI bitrot #772

Merged
merged 4 commits into from
Mar 6, 2025
Merged

Fix CI bitrot #772

merged 4 commits into from
Mar 6, 2025

Conversation

hacklschorsch
Copy link
Member

Fixes #764

Verified

This commit was signed with the committer’s verified signature.
newswangerd David Newswanger

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
@hacklschorsch hacklschorsch marked this pull request as draft March 5, 2025 20:43
@hacklschorsch
Copy link
Member Author

Marking as draft since it's the end of my day and I don't want to wait for CI. If it's all green, this is good to go.

@hacklschorsch
Copy link
Member Author

This changeset does fix the CI bitrot; marking it ready for review.

The two failing test suites (integration-tests (ubuntu-24.04, 3.9, 1_19) and integration-tests (ubuntu-24.04, 3.9, master)) are due to #766.

@hacklschorsch hacklschorsch marked this pull request as ready for review March 6, 2025 08:25
@hacklschorsch
Copy link
Member Author

hacklschorsch commented Mar 6, 2025

@meejah also implemented this in #774 to fix #773 which might be a duplicate of or overlap with #764.

The "upgrade ubuntu" part of this PR still is useful because ubuntu-20-image-is-closing-down, thus not closing this PR.

@meejah meejah merged commit 3941342 into tahoe-lafs:main Mar 6, 2025
16 of 18 checks passed
@hacklschorsch hacklschorsch deleted the 764.fix-ci branch March 6, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI has bitrotted
2 participants