Don't build (Haskell) benchmarks by default, use cabal bench
#119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke the tahoe-lafs-mobile build since its criterion can't be built with the android version of GHC. Use `cabal build --enable-benchmark` to build the benchmark from now on.
hacklschorsch
changed the title
cabal bench
|
Hey @meejah can we merge this? |
|
Or who could be interested in this - @sajith? |
sajith
reviewed
Mar 17, 2025
Yes, that's what #121 is for - happy if you can take a look there as well! |
|
Please do it when you get to it, no hurries. (I don't have the necessary permission)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the benchmark suite by default broke the tahoe-lafs-mobile build since its
criterioncan't be built with the android version of GHC.Also, building the benchmark takes ages.
Use
cabal build --enable-benchmarkto build the benchmark from now on, andcabal benchto run the benchmark (like specified in the Cabal documentation).