Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven integration tests #626

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Fix Maven integration tests #626

merged 1 commit into from
Mar 2, 2024

Conversation

tmortagne
Copy link
Collaborator

@tmortagne tmortagne commented Mar 1, 2024

Here are the fixed problems:

  • Looks like commons-codec is in fact used (indirectly probably) and since the shade plugin is configured to rename all references to org.apache.commons I included it (if you are sure it's only use in the Maven use case I guess an alternative would be to configure the shade plugin with a more restrictive package to rename)
  • The mojo seems to need a class located in ant so it cannot be scope provided
  • The mojo have a direct dependency on a class located in plexus-sec-dispatcher (to be honest I don't fully understand this one as plexus-sec-dispatcher seems to be part of Maven itself so not sure why it cannot find it, but adding this dependency definitely fix the class not found...)

@tmortagne
Copy link
Collaborator Author

tmortagne commented Mar 1, 2024

I also suggest #627 since the required Maven version seems a bit low for the shade plugin (seems to be what is causing the AppVeyor failure).

@tcurdt
Copy link
Owner

tcurdt commented Mar 2, 2024

I think it's time to port the windows test over to github anyway.
No point to deal with appveyor anymore.

@tcurdt tcurdt merged commit 49a9f87 into master Mar 2, 2024
5 of 6 checks passed
@tcurdt tcurdt deleted the fix-maven-integration-tests branch March 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants