Issue #628 : Updated the compiler source and target to 11 and added X… #629
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded Xlint unchecked
|
Thanks for the PR! Java 8 is still LTS. Despite being acient I am not sure if we can/should upgrade to 11 yet. But configuring the plugin sure should be done. |
|
@tcurdt Yes you are right, there is no guarantee that the upgrade will not break the code. I'll try to re-configure. |
|
Are you planing on updating the PR? |
|
@tcurdt Yes, working on it. |
harshal301002
deleted the
harshal301002-fix-warnings-and-deprecations-#628
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lint unchecked