Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore maven-archiver as a compile scoped dependency to fix reproducible builds #744

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

norrisjeremy
Copy link
Contributor

Restore maven-archiver as a compile scoped dependency to fix reproducible builds (#736)

Additionally use non-deprecated MavenArchiver.parseBuildOutputTimestamp() method

…ible builds (tcurdt#736)

Additionally use non-deprecated MavenArchiver.parseBuildOutputTimestamp() method
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.37%. Comparing base (92fee05) to head (e9a300e).
Report is 102 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #744      +/-   ##
============================================
+ Coverage     71.03%   71.37%   +0.34%     
- Complexity       96       97       +1     
============================================
  Files             7        7              
  Lines           580      587       +7     
  Branches         75       76       +1     
============================================
+ Hits            412      419       +7     
  Misses          121      121              
  Partials         47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcurdt tcurdt merged commit 6d88f60 into tcurdt:master Aug 27, 2024
7 checks passed
@tcurdt
Copy link
Owner

tcurdt commented Aug 27, 2024

Thanks!

@norrisjeremy norrisjeremy deleted the 20240826 branch August 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants