Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile on mingw64 #27

Merged
merged 19 commits into from
Jun 11, 2024
Merged

compile on mingw64 #27

merged 19 commits into from
Jun 11, 2024

Conversation

ngama75
Copy link
Contributor

@ngama75 ngama75 commented May 30, 2024

we will try to make it compile and work on windows (at least mingw)

todos

  • adjustments to cmake to deal with if (WIN32)
  • _win32 assembly files shall be written on the x64 calling convention (or c with intrinsics)
    • cplx/cplx_fft16_avx_fma_win32.s
    • cplx/cplx_ifft16_avx_fma_win32.s
    • @ssmiler reim4/reim4_fftvec_addmul_fma_win32.s -> convert to .c with intrinsics
    • @ssmiler reim4/reim4_fftvec_conv_fma_win32.s -> convert to .c with intrinsics
    • reim/reim_fft16_avx_fma_win32.s keep as .s
    • @ssmiler reim/reim_fft4_avx_fma_win32.s -> convert to .c with intrinsics
    • @ssmiler reim/reim_fft8_avx_fma_win32.s -> convert to .c with intrinsics
    • @ssmiler reim/reim_fftvec_addmul_fma_win32.s -> convert to .c with intrinsics?
    • reim/reim_ifft16_avx_fma_win32.s keep as .s
    • @ssmiler reim/reim_ifft4_avx_fma_win32.s -> convert to .c with intrinsics
    • @ssmiler reim/reim_ifft8_avx_fma_win32.s -> convert to .c with intrinsics
  • all 64-bit litterals shall be protected with INT64_C(1) instead of 1L since "L" on windows is 32 bits...
  • all printf formats that print 64-bit ints shall use the PRId64 / PRIu64 macros

definition of done:

  • it compile with mingw
    • on windows natively
    • cross-compile with x86_64-mingw-w64-gcc-posix
  • all unittests shall work
    • on windows natively (msys?)
    • in wine
  • readme/wiki documentation on how to compile on windows
  • readme/wiki documentation on how to cross-compile + execute

@ngama75 ngama75 requested a review from ssmiler May 30, 2024 13:26
@ngama75 ngama75 marked this pull request as ready for review June 10, 2024 17:35
@ngama75 ngama75 added the check-on-arm64 Check on arm64 label Jun 10, 2024
@ngama75 ngama75 changed the title WIP Ng/compile on mingw compile on mingw64 Jun 10, 2024
@mshih-sb mshih-sb merged commit ad1abe7 into main Jun 11, 2024
2 checks passed
@ngama75 ngama75 deleted the ng/compile-on-mingw branch August 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check-on-arm64 Check on arm64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants