Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to make new_ and delete_ call bytes_of #34

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix to make new_ and delete_ call bytes_of #34

merged 3 commits into from
Jun 14, 2024
+13 −32

Conversation

mshih-sb
Copy link
Collaborator

relating to: #33

Forgot to change the new_ and delete_ to only call bytes_of

Maurice Shih added 2 commits June 13, 2024 16:42
fix to make new_ and delete_ call bytes_of
Loading
Loading status checks…
3c35da1
fix for spqlios_debug
Loading
Loading status checks…
2deaa87
ngama75
ngama75 approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@ngama75 ngama75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!
In this case, these functions should be declared in the public vec_znx_arithmetic.h

@mshih-sb mshih-sb merged commit fdcab9e into main Jun 14, 2024
3 checks passed
@ngama75 ngama75 deleted the ms/new_del_fix branch August 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngama75 ngama75

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mshih-sb @ngama75