Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prod build last night included a DB migration to save the new activity read marker setting. This uncovered a bug with our latest posts logic — when the migration wipes all SQL data, the keyval store keeps its existing
headsSyncedAt
timestamp. This meanssyncLatestPost
thinks it already has messages that it doesn't.To fix, we'll now clear out that key anytime we purge the DB. I tried upgrading from an older version to confirm it works, but wanted to double check with y'all if purge is always called in these migration scenarios?
Another thought I had: if we have more of these sync optimization flags, it might be worth considering an optional
persistAfterMigration
storage item flag (analogous topersistAfterLogout
).