Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery: image posting UX #4541

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

gallery: image posting UX #4541

wants to merge 8 commits into from

Conversation

jamesacklin
Copy link
Member

@jamesacklin jamesacklin commented Mar 19, 2025

Fixes TLON-3761. This nearly completely overhauls GalleryInput to handle the UX changes we want for Gallery image uploads. I am preserving BigInput's current behavior until we make more progress on the Notebook design and back-end spec.

  • Only prompts the user for camera or photo library access permission if they tap the corresponding option, rather than slamming them with permission requests for both.
  • Does not use "cover" image fitting in the gallery image upload preview; uses "fit" method instead so that the longest edge occupies 100% of either the height or width of the preview canvas.
  • Moves the "Post" button to the header of the upload preview screen and does away with the confusing up-arrow button.
  • Eliminates the "…" and other controls that are erroneously present in the header of the upload preview screen.
  • Converts the image caption input to a native text input, since the caption is a single inline anyway.
  • Correctly routes the user to a version of the upload preview screen when they edit an image post; currently they're navigated to BigInput where they can only edit the caption and cannot see the image.

Progress thus far:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-19.at.13.36.18.mp4

@jamesacklin jamesacklin marked this pull request as ready for review March 19, 2025 17:47
@jamesacklin jamesacklin changed the title WIP: Gallery image posting UX gallery: image posting UX Mar 19, 2025
Copy link

linear bot commented Mar 19, 2025

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did find an issue with the "Edit post" button in the popover/context menu on the post not working on desktop, but I don't think that's related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants