Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Fix hosted uploads #4542

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Web: Fix hosted uploads #4542

merged 3 commits into from
Mar 19, 2025

Conversation

latter-bolden
Copy link
Member

@latter-bolden latter-bolden commented Mar 19, 2025

When checking hosted upload eligibility, we confirm the ship's URL is Tlon controlled. This check was failing on web because the http client's url property is not explicitly set. This updates the method to fall back to window location or env configuration during development.

Fixes TLON-3246

Copy link

linear bot commented Mar 19, 2025

@jamesacklin
Copy link
Member

Looks good to me, seems pretty safe.

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@latter-bolden latter-bolden merged commit 74312c6 into develop Mar 19, 2025
1 check passed
@latter-bolden latter-bolden deleted the lb/new-web-hosted-uploads branch March 19, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants